Basic Integration Deprecation #4069

joyceqin-stripe · 2024-09-27T18:20:24Z

Summary

Document of all public APIs removed by basic integration deprecation:
https://docs.google.com/document/d/170-0hg1SoSiNXOHiTuGST4b-tCJRzvNajST5Zeu11zA/edit?usp=sharing

Motivation

Basic integration deprecation

Testing

Changelog

emerge-tools · 2024-09-27T18:31:31Z

⚠️ 1 new unused protocol, 6 builds decreased size

Name	Version	Download	Change	Install	Change	Approval
StripeSize com.stripe.StripeSize	1.0 (1)	2.1 MB	⬇️ 324.6 kB (-13.5%)	6.8 MB	⬇️ 1.0 MB (-12.98%)	N/A
StripeApplePaySize com.stripe.StripeApplePaySize	1.0 (1)	437.6 kB	⬆️ 93 B (0.02%)	1.5 MB	⬇️ 100 B	N/A
StripeFinancialConnectionsSize com.stripe.StripeFinancialConnectionsSize	1.0 (1)	1.3 MB	⬇️ 314 B (-0.02%)	4.3 MB	⬇️ 120 B	N/A
StripePaymentsSize com.stripe.StripePaymentsSize	1.0 (1)	1.2 MB	⬇️ 477 B (-0.04%)	4.1 MB	⬇️ 1.3 kB (-0.03%)	N/A
StripePaymentsUISize com.stripe.StripePaymentsUISize	1.0 (1)	1.9 MB	⬇️ 824 B (-0.04%)	6.3 MB	⬇️ 2.7 kB (-0.04%)	N/A
StripePaymentSheetSize com.stripe.StripePaymentSheetSize	1.0 (1)	3.5 MB	⬇️ 1.3 kB (-0.04%)	10.4 MB	⬇️ 2.6 kB (-0.03%)	N/A

StripeSize 1.0 (1)
com.stripe.StripeSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 1.0 MB (-12.98%)
Total download size change: ⬇️ 324.6 kB (-13.5%)

Largest size changes

Item	Install Size Change
Packed Asset	⬇️ -3.0 kB
🗑 Stripe.STPPaymentContext	⬇️ -49.2 kB
🗑 Stripe.STPAddCardViewController	⬇️ -36.9 kB
DYLD.Exports	⬇️ -32.5 kB
🗑 Stripe.STPShippingAddressViewController	⬇️ -24.2 kB

View Treemap

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 100 B
Total download size change: ⬆️ 93 B (0.02%)

Largest size changes

Item	Install Size Change
Other	⬇️ -100 B

View Treemap

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

⚠️ Found new unused protocol: STPAnalyticsSerializer
⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 120 B
Total download size change: ⬇️ 314 B (-0.02%)

Largest size changes

Item	Install Size Change
Other	⬇️ -120 B

View Treemap

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 1.3 kB (-0.03%)
Total download size change: ⬇️ 477 B (-0.04%)

Largest size changes

Item	Install Size Change
🗑 StripePayments.STPPaymentMethodParams.label	⬇️ -1.2 kB
Other	⬇️ -148 B

View Treemap

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 2.7 kB (-0.04%)
Total download size change: ⬇️ 824 B (-0.04%)

Largest size changes

Item	Install Size Change
🗑 StripePayments.STPPaymentMethodParams.label	⬇️ -1.2 kB
Other	⬇️ -1.5 kB

View Treemap

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 2.6 kB (-0.03%)
Total download size change: ⬇️ 1.3 kB (-0.04%)

Largest size changes

Item	Install Size Change
🗑 StripePayments.STPPaymentMethodParams.label	⬇️ -1.2 kB
Other	⬇️ -1.4 kB

View Treemap

🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

github-actions · 2024-09-27T18:35:05Z

⚠️ Public API changes detected:

Stripe

- public var description: Swift.String {
- get
- }
- public var description: Swift.String {
- get
- }
- public var description: Swift.String {
- get
- }
- public var description: Swift.String {
- get
- }
- @available(*, deprecated, message: "This initializer previously configured publishableKey and stripeAccount via the STPPaymentConfiguration instance. This behavior is deprecated; set the STPAPIClient configuration, publishableKey, and stripeAccount properties directly on the STPAPIClient instead.")
- public init(configuration: Stripe.STPPaymentConfiguration)
- public var configuration: Stripe.STPPaymentConfiguration {
- @objc get
- @objc set
- }
- public init()
- public init(configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme)
- public var delegate: (any Stripe.STPAddCardViewControllerDelegate)?
- public var prefilledInformation: Stripe.STPUserInformation? {
- @objc get
- @objc set
- }
- public var customFooterView: UIKit.UIView? {
- @objc get
- @objc set(footerView)
- }
- public var apiClient: StripeCore.STPAPIClient
- public func tableView(_ tableView: UIKit.UITableView, estimatedHeightForRowAt indexPath: Foundation.IndexPath) -> CoreFoundation.CGFloat
- public func viewDidLayoutSubviews()
- public func updateAppearance()
- public func viewDidAppear(_ animated: Swift.Bool)
- public func handleCancelTapped(_ sender: Any?)
- public func paymentCardTextFieldDidChange(_ textField: StripePaymentsUI.STPPaymentCardTextField)
- public func paymentCardTextFieldWillEndEditing(forReturn textField: StripePaymentsUI.STPPaymentCardTextField)
- public func paymentCardTextFieldDidBeginEditingCVC(_ textField: StripePaymentsUI.STPPaymentCardTextField)
- public func paymentCardTextFieldDidEndEditingCVC(_ textField: StripePaymentsUI.STPPaymentCardTextField)
- public func paymentCardTextFieldDidBeginEditing(_ textField: StripePaymentsUI.STPPaymentCardTextField)
- public func numberOfSections(in tableView: UIKit.UITableView) -> Swift.Int
- public func tableView(_ tableView: UIKit.UITableView, numberOfRowsInSection section: Swift.Int) -> Swift.Int
- public func tableView(_ tableView: UIKit.UITableView, cellForRowAt indexPath: Foundation.IndexPath) -> UIKit.UITableViewCell
- public func tableView(_ tableView: UIKit.UITableView, willDisplay cell: UIKit.UITableViewCell, forRowAt indexPath: Foundation.IndexPath)
- public func tableView(_ tableView: UIKit.UITableView, heightForFooterInSection section: Swift.Int) -> CoreFoundation.CGFloat
- public func tableView(_ tableView: UIKit.UITableView, heightForHeaderInSection section: Swift.Int) -> CoreFoundation.CGFloat
- public func tableView(_ tableView: UIKit.UITableView, viewForHeaderInSection section: Swift.Int) -> UIKit.UIView?
- public func tableView(_ tableView: UIKit.UITableView, viewForFooterInSection section: Swift.Int) -> UIKit.UIView?
- public func viewWillTransition(to size: CoreFoundation.CGSize, with coordinator: any UIKit.UIViewControllerTransitionCoordinator)
- @objc deinit
- @objc func addCardViewControllerDidCancel(_ addCardViewController: Stripe.STPAddCardViewController)
- @objc func addCardViewController(_ addCardViewController: Stripe.STPAddCardViewController, didCreatePaymentMethod paymentMethod: StripePayments.STPPaymentMethod, completion: @escaping StripePayments.STPErrorBlock)
- @available(*, deprecated, renamed: "addCardViewController(_:didCreatePaymentMethod:completion:)", message: "Use addCardViewController(_:didCreatePaymentMethod:completion:) instead and migrate your integration to PaymentIntents. See https://stripe.com/docs/payments/payment-intents/migration/charges#read")
- @objc optional func addCardViewController(_ addCardViewController: Stripe.STPAddCardViewController, didCreateToken token: StripePayments.STPToken, completion: ((any Swift.Error)?) -> Swift.Void)
- @available(*, deprecated, renamed: "addCardViewController(_:didCreatePaymentMethod:completion:)", message: "Use addCardViewController(_:didCreatePaymentMethod:completion:) instead and migrate your integration to PaymentIntents. See https://stripe.com/docs/payments/payment-intents/migration/charges#read")
- @objc optional func addCardViewController(_ addCardViewController: Stripe.STPAddCardViewController, didCreateSource source: StripePayments.STPSource, completion: ((any Swift.Error)?) -> Swift.Void)
- case none
- case postalCode
- case full
- case name
- @available(*, deprecated, message: "Use STPBillingAddressFields.postalCode instead")
- case zip
- public init?(rawValue: Swift.UInt)
- public typealias RawValue = Swift.UInt
- public var rawValue: Swift.UInt {
- get
- }
- public func containsRequiredFields(_ requiredFields: Stripe.STPBillingAddressFields) -> Swift.Bool
- public func containsContent(for desiredFields: Stripe.STPBillingAddressFields) -> Swift.Bool
- public func containsRequiredShippingAddressFields(_ requiredFields: Swift.Set<StripePayments.STPContactField>?) -> Swift.Bool
- public func containsContent(forShippingAddressFields desiredFields: Swift.Set<StripePayments.STPContactField>?) -> Swift.Bool
- public class func applePayContactFields(from billingAddressFields: Stripe.STPBillingAddressFields) -> Swift.Set<PassKit.PKContactField>
- public class func pkContactFields(fromStripeContactFields contactFields: Swift.Set<StripePayments.STPContactField>?) -> Swift.Set<PassKit.PKContactField>?
- public var image: UIKit.UIImage {
- @objc get
- }
- public var templateImage: UIKit.UIImage {
- @objc get
- }
- public var label: Swift.String {
- @objc get
- }
- public var isReusable: Swift.Bool {
- @objc get
- }
- public func isEqual(_ object: Any?) -> Swift.Bool
- public var hash: Swift.Int {
- @objc get
- }
- public init()
- @objc deinit
- @objc func retrieveCustomer(_ completion: StripePayments.STPCustomerCompletionBlock?)
- @objc func listPaymentMethodsForCustomer(completion: StripePayments.STPPaymentMethodsCompletionBlock?)
- @objc func attachPaymentMethod(toCustomer paymentMethod: StripePayments.STPPaymentMethod, completion: StripePayments.STPErrorBlock?)
- @objc optional func detachPaymentMethod(fromCustomer paymentMethod: StripePayments.STPPaymentMethod, completion: StripePayments.STPErrorBlock?)
- @objc optional func updateCustomer(withShippingAddress shipping: StripePayments.STPAddress, completion: StripePayments.STPErrorBlock?)
- case FPX
- case unknown
- public init?(rawValue: Swift.Int)
- public typealias RawValue = Swift.Int
- public var rawValue: Swift.Int {
- get
- }
- public init(bankMethod: Stripe.STPBankSelectionMethod)
- public init(theme: Stripe.STPTheme?)
- public init(bankMethod: Stripe.STPBankSelectionMethod, configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme)
- public var delegate: (any Stripe.STPBankSelectionViewControllerDelegate)?
- public var apiClient: StripeCore.STPAPIClient
- @objc deinit
- public func numberOfSections(in tableView: UIKit.UITableView) -> Swift.Int
- public func tableView(_ tableView: UIKit.UITableView, numberOfRowsInSection section: Swift.Int) -> Swift.Int
- public func tableView(_ tableView: UIKit.UITableView, cellForRowAt indexPath: Foundation.IndexPath) -> UIKit.UITableViewCell
- public func tableView(_ tableView: UIKit.UITableView, willDisplay cell: UIKit.UITableViewCell, forRowAt indexPath: Foundation.IndexPath)
- public func tableView(_ tableView: UIKit.UITableView, heightForFooterInSection section: Swift.Int) -> CoreFoundation.CGFloat
- public func tableView(_ tableView: UIKit.UITableView, shouldHighlightRowAt indexPath: Foundation.IndexPath) -> Swift.Bool
- public func tableView(_ tableView: UIKit.UITableView, didSelectRowAt indexPath: Foundation.IndexPath)
- @objc(bankSelectionViewController:didCreatePaymentMethodParams:) func bankSelectionViewController(_ bankViewController: Stripe.STPBankSelectionViewController, didCreatePaymentMethodParams paymentMethodParams: StripePayments.STPPaymentMethodParams)
- case shipping
- case delivery
- public init?(rawValue: Swift.Int)
- public typealias RawValue = Swift.Int
- public var rawValue: Swift.Int {
- get
- }
- case valid
- case invalid
- public init?(rawValue: Swift.Int)
- public typealias RawValue = Swift.Int
- public var rawValue: Swift.Int {
- get
- }
- public var image: UIKit.UIImage {
- @objc get
- }
- public var templateImage: UIKit.UIImage {
- @objc get
- }
- public var label: Swift.String {
- @objc get
- }
- public var isReusable: Swift.Bool {
- @objc get
- }
- public var scrollView: UIKit.UIScrollView {
- @objc get
- @objc set
- }
- public func viewDidLoad()
- public func viewDidLayoutSubviews()
- public init(theme: Stripe.STPTheme?)
- public init(nibName nibNameOrNil: Swift.String?, bundle nibBundleOrNil: Foundation.Bundle?)
- public init?(coder aDecoder: Foundation.NSCoder)
- @objc deinit
- public var tableView: UIKit.UITableView? {
- @objc get
- }
- public func viewWillAppear(_ animated: Swift.Bool)
- public func tableView(_ tableView: UIKit.UITableView, heightForHeaderInSection section: Swift.Int) -> CoreFoundation.CGFloat
- public init(theme: Stripe.STPTheme?)
- public init(nibName nibNameOrNil: Swift.String?, bundle nibBundleOrNil: Foundation.Bundle?)
- public init?(coder aDecoder: Foundation.NSCoder)
- @objc deinit
- public init()
- public init(theme: Stripe.STPTheme?)
- public init(nibName nibNameOrNil: Swift.String?, bundle nibBundleOrNil: Foundation.Bundle?)
- public init?(coder aDecoder: Foundation.NSCoder)
- public func viewDidLoad()
- public func viewWillAppear(_ animated: Swift.Bool)
- public func viewWillDisappear(_ animated: Swift.Bool)
- public var preferredStatusBarStyle: UIKit.UIStatusBarStyle {
- @objc get
- }
- @objc deinit
- public init(keyProvider: any Stripe.STPCustomerEphemeralKeyProvider)
- public init(keyProvider: (any Stripe.STPCustomerEphemeralKeyProvider)?, apiClient: StripeCore.STPAPIClient)
- public func clearCache()
- public var includeApplePayPaymentMethods: Swift.Bool {
- @objc get
- @objc set(includeApplePayMethods)
- }
- public func retrieveCustomer(_ completion: StripePayments.STPCustomerCompletionBlock? = nil)
- public func updateCustomer(withShippingAddress shipping: StripePayments.STPAddress, completion: StripePayments.STPErrorBlock?)
- public func attachPaymentMethodToCustomer(paymentMethodId: Swift.String, completion: StripePayments.STPErrorBlock?)
- public func attachPaymentMethod(toCustomer paymentMethod: StripePayments.STPPaymentMethod, completion: StripePayments.STPErrorBlock?)
- public func detachPaymentMethodFromCustomer(paymentMethodId: Swift.String, completion: StripePayments.STPErrorBlock?)
- public func detachPaymentMethod(fromCustomer paymentMethod: StripePayments.STPPaymentMethod, completion: StripePayments.STPErrorBlock?)
- public func listPaymentMethodsForCustomer(completion: StripePayments.STPPaymentMethodsCompletionBlock? = nil)
- @objc deinit
- @objc deinit
- public func setAnimating(_ animating: Swift.Bool, animated: Swift.Bool)
- public var animating: Swift.Bool {
- @objc get
- @objc set(animating)
- }
- public var hidesWhenStopped: Swift.Bool {
- @objc get
- @objc set(hidesWhenStopped)
- }
- public var tintColor: UIKit.UIColor! {
- @objc get
- @objc set(tintColor)
- }
- public func layoutSubviews()
- @objc deinit
- public static var shared: Stripe.STPPaymentConfiguration
- public var applePayEnabled: Swift.Bool {
- @objc get
- @objc set
- }
- public var fpxEnabled: Swift.Bool
- public var requiredBillingAddressFields: Stripe.STPBillingAddressFields
- public var requiredShippingAddressFields: Swift.Set<StripePayments.STPContactField>?
- public var verifyPrefilledShippingAddress: Swift.Bool
- public var shippingType: Stripe.STPShippingType
- public var availableCountries: Swift.Set<Swift.String>
- public var companyName: Swift.String
- public var appleMerchantIdentifier: Swift.String?
- public var canDeletePaymentOptions: Swift.Bool
- public var cardScanningEnabled: Swift.Bool
- @available(*, deprecated, message: "additionalPaymentOptions has been removed. Set applePayEnabled and fpxEnabled on STPPaymentConfiguration instead.")
- public var additionalPaymentOptions: Swift.Int
- @available(*, deprecated, message: "If you used STPPaymentConfiguration.shared.publishableKey, use STPAPIClient.shared.publishableKey instead. If you passed a STPPaymentConfiguration instance to an SDK component, create an STPAPIClient, set publishableKey on it, and set the SDK component's APIClient property.")
- public var publishableKey: Swift.String? {
- @objc get
- @objc set(publishableKey)
- }
- @available(*, deprecated, message: "If you used STPPaymentConfiguration.shared.stripeAccount, use STPAPIClient.shared.stripeAccount instead. If you passed a STPPaymentConfiguration instance to an SDK component, create an STPAPIClient, set stripeAccount on it, and set the SDK component's APIClient property.")
- public var stripeAccount: Swift.String? {
- @objc get
- @objc set(stripeAccount)
- }
- public var description: Swift.String {
- @objc get
- }
- public func copy(with zone: ObjectiveC.NSZone? = nil) -> Any
- public init()
- @objc deinit
- public init(customerContext: Stripe.STPCustomerContext)
- public init(customerContext: Stripe.STPCustomerContext, configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme)
- public init(apiAdapter: any Stripe.STPBackendAPIAdapter)
- public init(apiAdapter: any Stripe.STPBackendAPIAdapter, configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme)
- public var apiAdapter: any Stripe.STPBackendAPIAdapter {
- get
- }
- public var configuration: Stripe.STPPaymentConfiguration {
- get
- }
- public var theme: Stripe.STPTheme {
- get
- }
- public var prefilledInformation: Stripe.STPUserInformation? {
- @objc get
- @objc set(prefilledInformation)
- }
- public var hostViewController: UIKit.UIViewController? {
- @objc get
- @objc set(hostViewController)
- }
- public var delegate: (any Stripe.STPPaymentContextDelegate)? {
- @objc get
- @objc set(delegate)
- }
- public var loading: Swift.Bool {
- @objc get
- }
- public var defaultPaymentMethod: Swift.String?
- public var selectedPaymentOption: (any Stripe.STPPaymentOption)? {
- @objc get
- }
- public var paymentOptions: [any Stripe.STPPaymentOption]? {
- @objc get
- }
- public var selectedShippingMethod: PassKit.PKShippingMethod? {
- get
- }
- public var shippingMethods: [PassKit.PKShippingMethod]? {
- @objc get
- }
- public var shippingAddress: StripePayments.STPAddress? {
- get
- }
- public var paymentAmount: Swift.Int {
- @objc get
- @objc set(paymentAmount)
- }
- public var paymentCurrency: Swift.String
- public var paymentCountry: Swift.String
- public var paymentSummaryItems: [PassKit.PKPaymentSummaryItem] {
- @objc get
- @objc set(paymentSummaryItems)
- }
- @available(macOS 14.0, iOS 17.0, *)
- public var applePayLaterAvailability: PassKit.PKApplePayLaterAvailability {
- @objc get
- @objc set
- }
- public var modalPresentationStyle: UIKit.UIModalPresentationStyle
- public var largeTitleDisplayMode: UIKit.UINavigationItem.LargeTitleDisplayMode
- public var paymentOptionsViewControllerFooterView: UIKit.UIView?
- public var addCardViewControllerFooterView: UIKit.UIView?
- public var apiClient: StripeCore.STPAPIClient {
- get
- set
- }
- public func retryLoading()
- public func presentPaymentOptionsViewController()
- public func pushPaymentOptionsViewController()
- public func presentShippingViewController()
- public func pushShippingViewController()
- public func requestPayment()
- public func paymentOptionsViewController(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController, didSelect paymentOption: any Stripe.STPPaymentOption)
- public func paymentOptionsViewControllerDidFinish(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController)
- public func paymentOptionsViewControllerDidCancel(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController)
- public func paymentOptionsViewController(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController, didFailToLoadWithError error: any Swift.Error)
- public func shippingAddressViewControllerDidCancel(_ addressViewController: Stripe.STPShippingAddressViewController)
- public func shippingAddressViewController(_ addressViewController: Stripe.STPShippingAddressViewController, didEnter address: StripePayments.STPAddress, completion: @escaping Stripe.STPShippingMethodsCompletionBlock)
- public func shippingAddressViewController(_ addressViewController: Stripe.STPShippingAddressViewController, didFinishWith address: StripePayments.STPAddress, shippingMethod method: PassKit.PKShippingMethod?)
- public func authenticationPresentingViewController() -> UIKit.UIViewController
- public func prepare(forPresentation completion: @escaping StripePayments.STPVoidBlock)
- @objc func paymentContext(_ paymentContext: Stripe.STPPaymentContext, didFailToLoadWithError error: any Swift.Error)
- @objc func paymentContextDidChange(_ paymentContext: Stripe.STPPaymentContext)
- @objc func paymentContext(_ paymentContext: Stripe.STPPaymentContext, didCreatePaymentResult paymentResult: Stripe.STPPaymentResult, completion: @escaping StripePayments.STPPaymentStatusBlock)
- @objc func paymentContext(_ paymentContext: Stripe.STPPaymentContext, didFinishWith status: StripePayments.STPPaymentStatus, error: (any Swift.Error)?)
- @objc optional func paymentContext(_ paymentContext: Stripe.STPPaymentContext, didUpdateShippingAddress address: StripePayments.STPAddress, completion: @escaping Stripe.STPShippingMethodsCompletionBlock)
- public func configure(with paymentResult: Stripe.STPPaymentResult)
- public var image: UIKit.UIImage {
- @objc get
- }
- public var templateImage: UIKit.UIImage {
- @objc get
- }
- public var label: Swift.String {
- @objc get
- }
- public var isReusable: Swift.Bool {
- @objc get
- }
- public var image: UIKit.UIImage {
- @objc get
- }
- public var templateImage: UIKit.UIImage {
- @objc get
- }
- public var isReusable: Swift.Bool {
- @objc get
- }
- @objc var image: UIKit.UIImage { get }
- @objc var templateImage: UIKit.UIImage { get }
- @objc var label: Swift.String { get }
- @objc var isReusable: Swift.Bool { get }
- public init(paymentContext: Stripe.STPPaymentContext)
- public init(configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme, customerContext: Stripe.STPCustomerContext, delegate: any Stripe.STPPaymentOptionsViewControllerDelegate)
- public init(configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme, apiAdapter: any Stripe.STPBackendAPIAdapter, delegate: any Stripe.STPPaymentOptionsViewControllerDelegate)
- public var prefilledInformation: Stripe.STPUserInformation? {
- @objc get
- @objc set
- }
- public var defaultPaymentMethod: Swift.String?
- public var paymentOptionsViewControllerFooterView: UIKit.UIView? {
- @objc get
- @objc set
- }
- public var addCardViewControllerFooterView: UIKit.UIView? {
- @objc get
- @objc set
- }
- public var apiClient: StripeCore.STPAPIClient
- public func dismiss(withCompletion completion: StripePayments.STPVoidBlock?)
- @available(*, unavailable, message: "Use one of the initializers declared in this interface instead.")
- public init(theme: Stripe.STPTheme?)
- @available(*, unavailable, message: "Use one of the initializers declared in this interface instead.")
- public init(nibName nibNameOrNil: Swift.String?, bundle nibBundleOrNil: Foundation.Bundle?)
- @available(*, unavailable, message: "Use one of the initializers declared in this interface instead.")
- public init?(coder aDecoder: Foundation.NSCoder)
- public func viewDidLayoutSubviews()
- public func viewDidAppear(_ animated: Swift.Bool)
- public func addCardViewControllerDidCancel(_ addCardViewController: Stripe.STPAddCardViewController)
- public func addCardViewController(_ addCardViewController: Stripe.STPAddCardViewController, didCreatePaymentMethod paymentMethod: StripePayments.STPPaymentMethod, completion: @escaping StripePayments.STPErrorBlock)
- @objc deinit
- @objc func paymentOptionsViewController(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController, didFailToLoadWithError error: any Swift.Error)
- @objc func paymentOptionsViewControllerDidFinish(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController)
- @objc func paymentOptionsViewControllerDidCancel(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController)
- @objc(paymentOptionsViewController:didSelectPaymentOption:) optional func paymentOptionsViewController(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController, didSelect paymentOption: any Stripe.STPPaymentOption)
- public var paymentMethod: StripePayments.STPPaymentMethod? {
- get
- }
- public var paymentMethodParams: StripePayments.STPPaymentMethodParams? {
- get
- }
- public var paymentOption: (any Stripe.STPPaymentOption)? {
- @objc get
- }
- public init(paymentOption: (any Stripe.STPPaymentOption)?)
- @objc deinit
- public init()
- public init(paymentContext: Stripe.STPPaymentContext)
- public init(configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme, currency: Swift.String?, shippingAddress: StripePayments.STPAddress?, selectedShippingMethod: PassKit.PKShippingMethod?, prefilledInformation: Stripe.STPUserInformation?)
- public var delegate: (any Stripe.STPShippingAddressViewControllerDelegate)?
- public func dismiss(withCompletion completion: StripePayments.STPVoidBlock?)
- @available(*, unavailable, message: "Use one of the initializers declared in this interface instead.")
- public init(theme: Stripe.STPTheme?)
- @available(*, unavailable, message: "Use one of the initializers declared in this interface instead.")
- public init(nibName nibNameOrNil: Swift.String?, bundle nibBundleOrNil: Foundation.Bundle?)
- public func viewDidAppear(_ animated: Swift.Bool)
- public func tableView(_ tableView: UIKit.UITableView, heightForHeaderInSection section: Swift.Int) -> CoreFoundation.CGFloat
- @objc deinit
- @objc func shippingAddressViewControllerDidCancel(_ addressViewController: Stripe.STPShippingAddressViewController)
- @objc(shippingAddressViewController:didEnterAddress:completion:) func shippingAddressViewController(_ addressViewController: Stripe.STPShippingAddressViewController, didEnter address: StripePayments.STPAddress, completion: @escaping Stripe.STPShippingMethodsCompletionBlock)
- @objc(shippingAddressViewController:didFinishWithAddress:shippingMethod:) func shippingAddressViewController(_ addressViewController: Stripe.STPShippingAddressViewController, didFinishWith address: StripePayments.STPAddress, shippingMethod method: PassKit.PKShippingMethod?)
- public func numberOfSections(in tableView: UIKit.UITableView) -> Swift.Int
- public func tableView(_ tableView: UIKit.UITableView, numberOfRowsInSection section: Swift.Int) -> Swift.Int
- public func tableView(_ tableView: UIKit.UITableView, cellForRowAt indexPath: Foundation.IndexPath) -> UIKit.UITableViewCell
- public func tableView(_ tableView: UIKit.UITableView, willDisplay cell: UIKit.UITableViewCell, forRowAt indexPath: Foundation.IndexPath)
- public func tableView(_ tableView: UIKit.UITableView, heightForFooterInSection section: Swift.Int) -> CoreFoundation.CGFloat
- public func tableView(_ tableView: UIKit.UITableView, viewForFooterInSection section: Swift.Int) -> UIKit.UIView?
- public func tableView(_ tableView: UIKit.UITableView, viewForHeaderInSection section: Swift.Int) -> UIKit.UIView?
- public var image: UIKit.UIImage {
- @objc get
- }
- public var templateImage: UIKit.UIImage {
- @objc get
- }
- public var label: Swift.String {
- @objc get
- }
- public var isReusable: Swift.Bool {
- @objc get
- }
- public static let defaultTheme: Stripe.STPTheme
- @available(*, deprecated, renamed: "defaultTheme", message: "Use defaultTheme instead")
- public static func `default`() -> Stripe.STPTheme
- public var primaryBackgroundColor: UIKit.UIColor
- public var secondaryBackgroundColor: UIKit.UIColor
- public var tertiaryBackgroundColor: UIKit.UIColor {
- @objc get
- }
- public var quaternaryBackgroundColor: UIKit.UIColor {
- @objc get
- }
- public var primaryForegroundColor: UIKit.UIColor
- public var secondaryForegroundColor: UIKit.UIColor
- public var tertiaryForegroundColor: UIKit.UIColor {
- @objc get
- }
- public var accentColor: UIKit.UIColor
- public var errorColor: UIKit.UIColor
- public var font: UIKit.UIFont {
- @objc get
- @objc set
- }
- public var emphasisFont: UIKit.UIFont {
- @objc get
- @objc set
- }
- public var barStyle: UIKit.UIBarStyle {
- @objc get
- @objc set
- }
- public var translucentNavigationBar: Swift.Bool
- public var smallFont: UIKit.UIFont {
- @objc get
- }
- public var largeFont: UIKit.UIFont {
- @objc get
- }
- public init()
- @objc deinit
- public func copy(with zone: ObjectiveC.NSZone? = nil) -> Any
- public var billingAddress: StripePayments.STPAddress?
- public var shippingAddress: StripePayments.STPAddress?
- public func setBillingAddress(with billingDetails: StripePayments.STPPaymentMethodBillingDetails)
- public func copy(with zone: ObjectiveC.NSZone? = nil) -> Any
- public init()
- @objc deinit
- @available(*, deprecated, message: "Use the `stp_theme` property instead")
- public func stp_setTheme(_ theme: Stripe.STPTheme)
- public var stp_theme: Stripe.STPTheme? {
- @objc get
- @objc set(theme)
- }

StripePayments

- public var label: Swift.String {
- @objc get
- }

If you are adding a new public API consider the following:

Do these APIs need to be public or can they be protected with @_spi(STP)?
If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

Does this require a breaking version change?
Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

github-actions · 2024-09-27T19:06:57Z

🚨 New dead code detected in this PR:

STPPhoneNumberValidator.swift:12 warning: Imported module 'StripeUICore' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

… into joyceqin-bideprecation

emerge-tools · 2024-10-15T16:40:23Z

📸 Snapshot Test

No snapshots generated

Name	Version	Approval
StripePaymentSheetSize com.stripe.StripePaymentSheetSize	1.0 (1)	N/A
StripePaymentsUISize com.stripe.StripePaymentsUISize	1.0 (1)	N/A
StripeSize com.stripe.StripeSize	1.0 (1)	N/A
StripeFinancialConnectionsSize com.stripe.StripeFinancialConnectionsSize	1.0 (1)	N/A
StripeApplePaySize com.stripe.StripeApplePaySize	1.0 (1)	N/A
StripePaymentsSize com.stripe.StripePaymentsSize	1.0 (1)	N/A

🛸 Powered by Emerge Tools

… into joyceqin-bideprecation

joyceqin-stripe · 2024-10-16T20:59:12Z

StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentMethodType.swift

        default:
-            return label


Used to return its STPPaymentOption label, but STPPaymentOption is no longer, so I copied over what label would have been

porter-stripe · 2024-10-25T18:22:57Z

Stripe/StripeiOS/Source/STPAPIClient+PushProvisioning.swift

+    // MARK: Helpers
+
+    /// A helper method that returns the Authorization header to use for API requests. If ephemeralKey is nil, uses self.publishableKey instead.
+    func authorizationHeader(using ephemeralKey: STPEphemeralKey? = nil) -> [String: String] {


Was this moved from somewhere?

Yes, this was from STPAPIClient+BasicUI.swift, but I moved it into the STPAPIClient+PushProvisioning file because that's where the function was used and I didn't want there to be any leftover +BasicUI files

porter-stripe

One question about the added code, otherwise looks good.

davidme-stripe

Looks good! Just had a few comments on tests that I think we could keep

Stripe/StripeiOSTests/STPAPIClientTest.swift

davidme-stripe · 2024-10-25T19:00:27Z

Stripe/StripeiOSTests/STPAddressTests.swift

@@ -140,334 +140,6 @@ class STPAddressTests: XCTestCase {
        XCTAssertNil(address.country)
    }

-    func testPKContactValue() {


Can we keep these around? I think they're still used.

Most of these tests use containsRequiredFields or containsContent, which are being removed from STPAddress+BasicUI.swift. I can restore testPKContactValue, I think that one's still fine

Ah, got it! Nw then, I think we can delete the ones that use containsRequiredFields or containsContent.

deleted basic integration api and everything else that prevented build

69d1d70

ui examples builds

bde2343

tests build

7c993dc

joyceqin-stripe added 2 commits September 27, 2024 14:53

new .periphery.yml

53e6373

modified .periphery

9d17fd8

joyceqin-stripe changed the title ~~Basic Integration Deprecation~~ [iOS] Basic Integration Deprecation Sep 30, 2024

joyceqin-stripe changed the title ~~[iOS] Basic Integration Deprecation~~ Basic Integration Deprecation Sep 30, 2024

joyceqin-stripe added 7 commits September 30, 2024 12:08

Merge branch 'master' into joyceqin-bideprecation

8c6ad95

Trigger Build

46c0b5e

Merge branch 'joyceqin-bideprecation' of github.com:stripe/stripe-ios…

bd357ff

… into joyceqin-bideprecation

Update .periphery.yml

fe4f118

no changes .periphery

d3b3abc

merge conflict

105364d

periphery detected dead code

6b57a59

joyceqin-stripe marked this pull request as ready for review September 30, 2024 21:20

joyceqin-stripe requested review from a team as code owners September 30, 2024 21:20

joyceqin-stripe marked this pull request as draft September 30, 2024 21:21

joyceqin-stripe and others added 9 commits September 30, 2024 14:21

Merge branch 'master' into joyceqin-bideprecation

12ff783

Merge branch 'master' into joyceqin-bideprecation

72c37fa

retain public false

8dc7b16

periphery invalid keys

ed7373f

Merge branch 'master' into joyceqin-bideprecation

edc1956

new localized strings

f53ee19

Merge branch 'joyceqin-bideprecation' of github.com:stripe/stripe-ios…

e4a473f

… into joyceqin-bideprecation

checkout Package.resolved from master

41b6d1a

try different schemes .periphery.yml

d062fed

joyceqin-stripe added 4 commits October 14, 2024 16:27

update integrationtester ui test to remove fpx

503564e

restore unused but public func

575b43a

Merge branch 'master' into joyceqin-bideprecation

3d371cb

Merge branch 'master' into joyceqin-bideprecation

f87affa

joyceqin-stripe added 3 commits October 15, 2024 09:57

Merge branch 'master' into joyceqin-bideprecation

5b1c29a

removed fpx bank icons

3f5dc8d

Merge branch 'joyceqin-bideprecation' of github.com:stripe/stripe-ios…

cc478b1

… into joyceqin-bideprecation

porter-stripe added the basic integration deprecation label Oct 16, 2024

joyceqin-stripe added 2 commits October 16, 2024 13:32

Merge branch 'master' into joyceqin-bideprecation

b9400fd

Merge branch 'master' into joyceqin-bideprecation

cff552d

joyceqin-stripe commented Oct 16, 2024

View reviewed changes

joyceqin-stripe added 2 commits October 22, 2024 14:21

Merge branch 'master' into joyceqin-bideprecation

50fe896

Merge branch 'master' into joyceqin-bideprecation

cc814de

joyceqin-stripe marked this pull request as ready for review October 24, 2024 18:19

joyceqin-stripe requested a review from davidme-stripe October 24, 2024 18:23

Merge branch 'master' into joyceqin-bideprecation

e9d1de2

porter-stripe reviewed Oct 25, 2024

View reviewed changes

porter-stripe previously approved these changes Oct 25, 2024

View reviewed changes

davidme-stripe reviewed Oct 25, 2024

View reviewed changes

joyceqin-stripe added 2 commits October 25, 2024 12:49

restored testPKContactValue

4ce1440

restored STPAPIClientTest

b20690c

joyceqin-stripe dismissed porter-stripe’s stale review via b20690c October 25, 2024 19:54

Merge branch 'master' into joyceqin-bideprecation

24399a3

joyceqin-stripe requested review from davidme-stripe and porter-stripe October 25, 2024 20:24

porter-stripe approved these changes Oct 25, 2024

View reviewed changes

davidme-stripe approved these changes Oct 25, 2024

View reviewed changes

joyceqin-stripe merged commit 3606eeb into master Oct 25, 2024
7 checks passed

joyceqin-stripe deleted the joyceqin-bideprecation branch October 25, 2024 20:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic Integration Deprecation #4069

Basic Integration Deprecation #4069

joyceqin-stripe commented Sep 27, 2024 •

edited

Loading

emerge-tools bot commented Sep 27, 2024 •

edited

Loading

github-actions bot commented Sep 27, 2024 •

edited

Loading

github-actions bot commented Sep 27, 2024 •

edited

Loading

emerge-tools bot commented Oct 15, 2024 •

edited

Loading

joyceqin-stripe Oct 16, 2024

porter-stripe Oct 25, 2024

joyceqin-stripe Oct 25, 2024

porter-stripe left a comment

davidme-stripe left a comment

davidme-stripe Oct 25, 2024

joyceqin-stripe Oct 25, 2024 •

edited

Loading

davidme-stripe Oct 25, 2024

Basic Integration Deprecation #4069

Basic Integration Deprecation #4069

Conversation

joyceqin-stripe commented Sep 27, 2024 • edited Loading

Summary

Motivation

Testing

Changelog

emerge-tools bot commented Sep 27, 2024 • edited Loading

⚠️ 1 new unused protocol, 6 builds decreased size

StripeSize 1.0 (1)com.stripe.StripeSize

StripeApplePaySize 1.0 (1)com.stripe.StripeApplePaySize

StripeFinancialConnectionsSize 1.0 (1)com.stripe.StripeFinancialConnectionsSize

StripePaymentsSize 1.0 (1)com.stripe.StripePaymentsSize

StripePaymentsUISize 1.0 (1)com.stripe.StripePaymentsUISize

StripePaymentSheetSize 1.0 (1)com.stripe.StripePaymentSheetSize

github-actions bot commented Sep 27, 2024 • edited Loading

Stripe

StripePayments

github-actions bot commented Sep 27, 2024 • edited Loading

emerge-tools bot commented Oct 15, 2024 • edited Loading

📸 Snapshot Test

No snapshots generated

joyceqin-stripe Oct 16, 2024

Choose a reason for hiding this comment

porter-stripe Oct 25, 2024

Choose a reason for hiding this comment

joyceqin-stripe Oct 25, 2024

Choose a reason for hiding this comment

porter-stripe left a comment

Choose a reason for hiding this comment

davidme-stripe left a comment

Choose a reason for hiding this comment

davidme-stripe Oct 25, 2024

Choose a reason for hiding this comment

joyceqin-stripe Oct 25, 2024 • edited Loading

Choose a reason for hiding this comment

davidme-stripe Oct 25, 2024

Choose a reason for hiding this comment

joyceqin-stripe commented Sep 27, 2024 •

edited

Loading

emerge-tools bot commented Sep 27, 2024 •

edited

Loading

StripeSize 1.0 (1)
com.stripe.StripeSize

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

github-actions bot commented Sep 27, 2024 •

edited

Loading

github-actions bot commented Sep 27, 2024 •

edited

Loading

emerge-tools bot commented Oct 15, 2024 •

edited

Loading

joyceqin-stripe Oct 25, 2024 •

edited

Loading